MetaGPT icon indicating copy to clipboard operation
MetaGPT copied to clipboard

Feature/import repo

Open iorisa opened this issue 1 year ago • 4 comments

Features The Import process allows external existing projects to continue incrementally adding requirements. Deps:

  • #1053
  • #1055
  • #1068
  • #1099
  • #1103

iorisa avatar Mar 27 '24 14:03 iorisa

Codecov Report

Attention: Patch coverage is 24.40801% with 415 lines in your changes are missing coverage. Please review.

Project coverage is 33.55%. Comparing base (5180980) to head (33ca447).

Files Patch % Lines
metagpt/actions/import_repo.py 22.62% 106 Missing :warning:
metagpt/tools/libs/software_development.py 21.49% 84 Missing :warning:
metagpt/utils/repo_to_markdown.py 12.76% 41 Missing :warning:
metagpt/actions/extract_readme.py 36.20% 37 Missing :warning:
metagpt/roles/engineer.py 20.45% 35 Missing :warning:
metagpt/utils/common.py 10.81% 33 Missing :warning:
metagpt/utils/git_repository.py 22.85% 27 Missing :warning:
metagpt/context.py 20.00% 20 Missing :warning:
metagpt/tools/libs/shell.py 41.17% 10 Missing :warning:
metagpt/tools/libs/git.py 53.84% 6 Missing :warning:
... and 8 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1125       +/-   ##
===========================================
- Coverage   74.84%   33.55%   -41.30%     
===========================================
  Files         278      283        +5     
  Lines       16848    17333      +485     
===========================================
- Hits        12610     5816     -6794     
- Misses       4238    11517     +7279     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 27 '24 14:03 codecov-commenter

Previously submitted features were all designed to support this feature, so it merges them.

iorisa avatar Mar 28 '24 08:03 iorisa

I still think some examples should be provided. Also, the description of this PR "The Import process allows external existing projects to continue incrementally adding requirements." does not seem to be correct. I don't seem to see the possibility that this process will work

geekan avatar Mar 28 '24 08:03 geekan

You're right, there are still the following issues with the importing process:

  1. Requirement merging. Corresponding to the PRD's "Requirement Pool" — the software summary in the readme is not equivalent to requirements; generating "Requirement Pool" by summary leads to misinterpretation of requirements and incorrect code changes. So, this issue remains to be resolved.
  2. Design filtering. New requirements need filtering out areas that won't be changed. The current process still involves rewriting the entire codebase.

These functionalities rely on the bug fixing and new requirement evaluation processes, as well as the optimization based on their effectiveness. Currently, only the dependencies between various stages have been resolved. While this makes the process executable, it is not yet perfect.

iorisa avatar Mar 29 '24 03:03 iorisa