Peter Gedeck

Results 16 comments of Peter Gedeck

Here is the code where the type information is not correct. ``` RDKit::ROMol *cleanupHelper(const RDKit::ROMol *mol, python::object params) { return msHelper( mol, params, static_cast< RDKit::RWMol *(*)(const RDKit::RWMol *, const RDKit::MolStandardize::CleanupParameters...

I don't know. I use the package in an upcoming book (https://gedeck.github.io/mistat-code-solutions/IndustrialStatistics/) and was hoping that it would get fixed soon. Unfortunately, this hasn't happened yet, so I incorporated the...

Thank you for the contribution. I'm reluctant to add it to the repository in the current form. However, we may come up with a way to do it. I have...

There is no need to have write access. Instead of creating a new repository, you fork this one and make changes in the forked repository. You can then create a...

The command ``` print(np.mean(perm_diffs > mean_b - mean_a)) ``` is correct. It probably warrants some explanation. `perm_diffs` is a vector of possible differences of means for A and B. `mean_b...

This issue was reported before #23 but never got the versions. The problem is that `mean_a` and `mean_b` are `float` and not `numpy.float64`. The means come from `pandas`, so it...

My versions are: Python 3.9.4, numpy 1.20.2, and pandas 1.2.4 I looked at the various pandas release notes since 1.1.3 but couldn't pinpoint when it was fixed. There are several...

The scipy version that I use is `scipy==1.7.0`. I just downgraded my pandas and numpy version to yours and the code still works. It could be an OS related issue....

Did you try: ``` print(np.mean(np.array(perm_diffs) > mean_b - mean_a)) ```