Gisle Dankel
Gisle Dankel
> ``` > $ grep cudart -r build/third_party/tensorpipe > build/third_party/tensorpipe/CMakeFiles/Export/share/cmake/Tensorpipe/TensorpipeTargets.cmake: INTERFACE_LINK_LIBRARIES "tensorpipe;/usr/local/cuda-11.1/lib64/libcudart.so" > ``` > > I am pretty sure `libcudart` is coming from `tensorpipe`. I suspect that if we...
The intention is that for jemalloc version > 5, that definition should not be compiled (see folly/experimental/JemallocHugePageAllocator.cpp:27). Can you check what JEMALLOC_VERSION_MAJOR reports?
@ftiasch Thanks! Could you also please try commenting out line 26 and see if anything changes: //#include It's likely the case that jemalloc.h is getting included via one of the...
OK, you can try this patch to JemallocHugePageAllocator.cpp: ``` @@ -40,6 +40,8 @@ #define MALLOCX_ARENA(x) 0 #define MALLOCX_TCACHE_NONE 0 #define MADV_HUGEPAGE 0 + +#ifndef JEMALLOC_VERSION_MAJOR typedef struct extent_hooks_s extent_hooks_t; typedef...
I'll submit a proper patch - there might be an issue with jemalloc version < 5 as well if the header is included via another header. By the way, just...
There seems to be an issue with the FOLLY_HAVE_LIBJEMALLOC as well. You can try to replace that with FOLLY_USE_JEMALLOC (in the same file). This is probably the better fix in...
We did merge a different patch that seems to have worked for most folks. I will also merge the above.
I'll be happy to review - just need to find some time, please be a little patient while I refresh my memory ;)
Hi, I seem to recall some refactoring diffs not yet published to GitHub that addresses most of this, or maybe they were published but I missed them in my search....
@robieta @aaronenyeshi @chaekit @briancoutinho Could one of you dig up the other refactoring patch(es) and post them to github? Specifically I introduced a composite profiler class, removed the ActivityProfilerProxy etc....