Giuseppe Burtini
Giuseppe Burtini
I will investigate before merging.
There is lots of code in the library which is missing tests right now. SANN should work, but I do not believe has unit tests.
13:00 here. I'm on the west coast. Keep up the good work, I will review when you're all done. Sleep well!
Right, the tests for SANN are currently not PHPUnit. They were written by another author who submitted a PR. I don't have time to rewrite them as PHPUnit right now....
Sorry, I'm slow on this. I recommend just commenting out that test for now (and leaving no active tests for SANN) and eventually I will either write a proper test...
Does this pull request require changes to the tests?
Hey @mossadal, Sorry, I hadn't seen the issue. Please feel free to make this decision yourself. In general, I tried to remain congruent with Wikipedia's "first" expository parametrization, but this...
Yep, I agree - let's go with the Mathematica standard. Feel free to institute semver in your next PR if we haven't already done that. I have it on my...
I unfortunately don't have a ton of time for development on this project at the moment, but I agree with the need and would be very eager to merge pull...