George Burgess IV

icon indicating an email [email protected]

Results 7 comments of George Burgess IV

Crash with `llvm-15` + exporting a new libc++ std::string

Good catch, @greg904 :) I'll ask folks to verify whether #2239's PR fixes this on our side, and close if so.

Crash with `llvm-15` + exporting a new libc++ std::string

Yeah, looks like that fixes things. Closing this out; thanks again!

[libc] fix behavior of strrchr(x, '\0')

friendly ping :)

[libc] fix behavior of strrchr(x, '\0')

friendly ping :)

[libc] fix behavior of strrchr(x, '\0')

Oh, I didn't realize that I missed this: > I thought the nice thing about ASSERT_EQ or in this case ASSERT_STREQ is that when the assertion fails, it tells you...

[libc] fix behavior of strrchr(x, '\0')

So, better response: > I thought the nice thing about ASSERT_EQ or in this case ASSERT_STREQ is that when the assertion fails, it tells you what was expected vs what...

[libc] fix behavior of strrchr(x, '\0')

Thanks!