ros_gz icon indicating copy to clipboard operation
ros_gz copied to clipboard

Galactic to ros2

Open mjcarroll opened this issue 1 year ago • 1 comments

➡️ Forward port

Partial forward port.

Port galactic to ros2

Branch comparison: https://github.com/ignitionrobotics/ros_gz/compare/ros2...galactic

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

mjcarroll avatar Jul 08 '22 22:07 mjcarroll

CI is green, is this ready for review ?

Not quite, I'm about half way there. It's a pretty massive forward port. Will remove draft status when it is ready

mjcarroll avatar Jul 11 '22 16:07 mjcarroll

Okay, this is now ready for a review.

It's a pretty massive PR... I'm sorry, but it will bring ros2 completely up to date afaict.

mjcarroll avatar Sep 23 '22 00:09 mjcarroll

DCO needs fixing :O

methylDragon avatar Sep 23 '22 00:09 methylDragon

DCO needs fixing :O

DCO is always a bit finicky around merge commits, I'll see what I can do.

mjcarroll avatar Sep 23 '22 01:09 mjcarroll

Oh yeah, I can force DCO to pass :zipper_mouth_face:

mjcarroll avatar Sep 23 '22 01:09 mjcarroll