gz-gui
gz-gui copied to clipboard
Disable shadows when viewing point cloud markers
🦟 Bug fix
Summary
The markers displayed by the Point Cloud widget cast shadows, which may not be intended.
To reproduce.
- Run a point cloud publisher, for example by using the executable from
gz-gui/examples/standalone/point_cloud. - Open an empty world, add the Point Cloud widget, then display the data. Any example world will do provided it includes lighting and a ground plane.
Before
After
The change adds a default material to the marker message. This triggers the MarkerManager system to handle the material, and the SetMaterial method for markers in the render engine disables shadow casting.
There is also a small change to the CMakeLists.txt in the point cloud example to allow it to be built on macOS (Darwin).
Checklist
- [x] Signed all commits for DCO
- [ ] Added tests
- [ ] Updated documentation (as needed)
- [ ] Updated migration guide (as needed)
- [ ] Consider updating Python bindings (if the library has them)
- [x]
codecheckpassed (See contributing) - [x] All tests passed (See test coverage)
- [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers
- [ ] Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)
Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.