Gavrie Philipson
Gavrie Philipson
Agreed, good find. The right thing to do is probably to remove the `#[allow(clippy::not_unsafe_ptr_arg_deref)]` and mark the functions as `unsafe` instead. Also, functions like `call_reply_type` should definitely not be in...
I agree; it would be nice to be able to support non-UTF-8 data. I'm not worried about breaking the API; we're still in an early stage with this project and...
@SDesch I mostly agree with your conclusion regarding cross compilation -- it's a bit complicated since we're not talking about pure Rust code, but code that links to C code...
@SDesch I mostly agree with your conclusion regarding cross compilation -- it's a bit complicated since we're not talking about pure Rust code, but code that links to C code...
@slavak > 1. I think the variadic call convention better communicates the limitations of the API. Accepting a slice implies a generality we can't support with the underlying C API....
@gkorland please explain what you want to do in this ticket.
@let4be thanks for reporting the issue -- though it would have been better to create a new issue instead of commenting on the existing one. @gkorland any ideas here?
Looks like a crash. Could you provide the Redis logs please?
@unrealhoang Thanks for opening the issue. This is indeed something that needs careful consideration; we’ll take a look to see what the best solution would be.
@unrealhoang @tamird I've been looking into this for a bit. We currently use create owned strings from the arguments that Redis handles to us. It might be a good idea...