Gavin King
Gavin King
I plan to merge this soon if there are no objections.
> Not sure how I feel about inner types for this @sebersole What would you do instead? I don't want to further crowd out the toplevel namespace. And, sure, we...
Merging this. We can try it out in M1 and see how we like it and if we want to change anything.
> I have a hard time justifying the removal of `TypedQuery.getResultList`, which is currently the pattern that we want applications using. Do we really need the new `List getResults()` method?...
@njr-11 I have made both of your suggested changes. WDYT now?
> I'm still wondering if we can avoid adding `getResults()` to avoid the duplication That's what I tried with the competing PR, but I feel like that one just got...
After several backchannel discussions with various people, the sense I took away was: "if we're going to do this, do #842". I'm therefore closing this PR.
> Do we really need the new `List getResults()` method? FTR, this was the strongest argument against this option. This, and the fact that `TypedQuery` continues to have an `executeUpdate()`...
Wondering if we should make `FetchType` a `FetchOption`. That would be a bit of a change to the model though. We would then have `LAZY` nodes in the graph instead...
@starksm64 @scottmarlow @bstansberry please take a look at this.