Gavin King
Gavin King
Alright, I will merge it. As I said, this is still a trial balloon to see what feedback we get and what the fallout looks like.
@anija-anil would you given this a review, please?
> But I'm not sure it is worth it to remove & move the existing constants that were present in 3.2 in order to achieve that. Applications would need to...
>The JdbcProperties group seems like it is trying to be two things that are not the same: a group of properties by which the persistence provider can create a DataSource...
> You mean that these two don't fit, is that right? I added `TimeoutProperties` as a container for those two.
Hrm. I guess I think the most reasonable solution is a `BatchProperties` interface for just those two. I know the "fetch size" isn't usually considered a "batch size" but really...
Well, OK, or, as you say `ConnectionProperties` and `JdbcProperties`.
There, I pushed your solution.
FTR the unit properties are actually defined specifically for the purpose of use in Java SE. See section 9.7 of the JPA 3.2 spec. It's not very clear from the...
Any objections to just doing this? @sebersole? I understand that @njr-11 is in favor of it now that his objections were addressed. Anyone else?