Gavin Barron

Results 176 comments of Gavin Barron

OP is interested in `logoutCompleted` not `loginCompleted`

I wonder if it's the second attempt to clear the cached data after provider.logout and there not being an active account?

There's no check there about the number of accounts, just the configuration of the provider.

We need to have the ACS team expose the `active` parameter for `onRenderSuggestionItem` in the typings Added further commentary to the existing issue on this front here https://github.com/Azure/communication-ui-library/issues/3836#issuecomment-1967447431

I have just updated that page to specify the correct node version and setup steps for yarn

I really like this idea. The one thing that I'm cautious on is that the coverage only reports on the files it sees during testing, not the files that are...

@sebastienlevert do we have any indication of relative stability of this model and timelines on moving it to v1?

It feels like something that's unlikely to change shape underneath us, so I'm reasonably comfortable to proceed. We'll need to be pretty defensive incase the schema does change though. We...