microsoft-graph-toolkit
microsoft-graph-toolkit copied to clipboard
microsoftgraph
Allow to disable initial users suggestion list in People Picker
Proposal: Allow to disable initial users suggestion list in People Picker
Description
Currently, there's no option to disable the dropdown list that appears when the search result is empty.
Rationale
The feature to disable empty dropdown search results should be added to enhance the impartiality of user selection processes in various applications. This feature is crucial in scenarios where unbiased decision-making is important, such as awarding individuals or selecting candidates for specific roles or recognitions.
Preferred Solution
Maybe an attribute like show-empty-search-results:
<mgt-people-picker show-empty-search-results="false"></mgt-people-picker>
@FelipeCostaGualberto for a little bit more clarity on your rationale, are you initializing the picker with other properties like userFilters? By default, <mgt-people-picker></mgt-people-picker> will have people from your contacts. Are you suggestion that this be completely disabled, and you only see suggestions after you start typing a name?
@musale
re you suggestion that this be completely disabled, and you only see suggestions after you start typing a name?
Yes, I'm suggesting exactly this: if the user hasn't typed anything in the input box, it should not show the suggestion list.
I think this is a fair request and would not be too difficult to achieve. Having a disable-suggestions attribute would allow to disable this functionality and then only render the search based on the configured properties of the component. @FelipeCostaGualberto would your be interested into send a PR our way to include this change? Thanks!
Hi @sebastienlevert ,
Thanks for thinking of me for this. I'm not skilled in frontend stuff like what's needed for the Microsoft Graph Toolkit. So I might not be the best fit for implementing this feature.
However, I tried cloning the repo, then yarn and then yarn start and I got the errors
ERROR: "watch" exited with 1.
ERROR: "watch:serve" exited with 1.
I might be something I did wrong following the contribute documentation.
Do you have other logs you can share? Also, please use this wiki for contribution guides! https://github.com/microsoftgraph/microsoft-graph-toolkit/wiki#setup-the-development-environment
I have just updated that page to specify the correct node version and setup steps for yarn
At the moment, this is not something we're likely to prioritize. That being said, the Graph Toolkit is an open source project and we'll be happy to support and review if you want to contribute to its codebase! Please let us know if you'd be happy to help and implement this capability. If not, it's absolutely fine, we'll go and close the issue and might re-open it later if we reconsider our priorities. Thanks!
Hello guys, thanks for opening space so I can contribute on this feature. Unfortunately, I don't have the skills set to do so. Thanks!
Thanks! We will be looking into when this could land. It's something that impacts multiple customers and we want to have a solution.