Gautham Nair
Gautham Nair
@kaos @grihabor @sureshjoshi I just took a look at the Sql PR. What code_quality_tool could have done (in the form introduced in https://github.com/pantsbuild/pants/pull/20135 ) is: - Provide lint/fix/fmt on `*.sql`...
@kaos I am going to try to begin adding tests here.
@kaos , I've become uncomfortable with a part of the proposed API for 'templated backends'. Config args are currently represented as plain extra args to the entrypoints in `register.py`. So...
Actually, scratch that, been thinking about this in an unsound way. It is problematic to have separate methods `rules`, `target_types` etc that separately accept the configuration values. It is possible...
@kaos , the way the PR is currently one does have to refer to the configured backends still in `backend_packages`. I think it will be fine to change the `template`...
@kaos This comment takes your suggestion and see how to tie it together in a self-consistent way of talking/thinking about backends. What you are proposing is an interesting formulation. ##...
Sorry, @thejcannon , what I mean by: > We can propose that all backends are "generated"/"templated" Is just a conceptual change, but does not require any change in toml. Its...
> These are definitely not packages in any sense that overlaps with existing usage. I'm not even sure if they'd count as backends? Conceptually, they're jazzed up code generators. Very...
@benjyw The PR is itself in a good state, but there is debate about whether this is the right move or whether what is offered here will provide value greater...
https://github.com/pantsbuild/pants/pull/20122 demonstrates _a_ way to get the shell args through for the narrow case of `test.extra_env_vars`. It does so by: - grab the environment present locally - merge it with...