Andrew Gaul

icon indicating a website link http://gaul.org/

icon company @DeepStructure-io icon location San Francisco icon location Interested in entrepreneurship, distributed computing, storage, and free software. Previously at @Google, @bouncestorage, @maginatics, and @riverbed.

Results 653 comments of Andrew Gaul

Add missing locking and fix incorrect annotations

I think it is getting too confusing juggling the clang-tidy infrastructure changes with the independent fixes. Let me try to merge more of the former so that the latter is...

Cannot use bucket folders created outside s3fs

@vicr-np could you share how this folder was made? The expected format for this value is an integer UID. I looked through GitHub but cannot find a similar colon-separated format....

Add /healthz endpoint for health monitoring in S3Proxy

I'm preparing a new release so please try to address my comments before the weekend.

Add /healthz endpoint for health monitoring in S3Proxy

@Aazme could you finish this PR?

Add /healthz endpoint for health monitoring in S3Proxy

@Aazme could you finish this PR?

Upgrade to S3Proxy 2.1.0

Note that some tests fail. Are these pre-existing issues: ``` OOPS: 80 passed, 6 skipped, 31 FAILED ```

invalid checkstyle configuration

I don't use Windows but have gotten new files in PRs with CRLF that I manually need to run `dos2unix` to repair. I want to ensure that all merged code...

Should recommend Path.of() instead of Paths.get()

Maybe just add another violation for `Paths.get` recommending `Path.of`? This will annoy users who fix one violation and are greeted by a second but at least gives them a path...

Should recommend Path.of() instead of Paths.get()

I don't think the intent should be to create a Path to call toFile. Rather, codebases should adopt Path throughout, e.g., https://github.com/gaul/s3proxy/commit/26dd4a46e9d017c037bc53692d2c9a64b7d387fa. Perhaps this seems pedantic to some applications but...

Should recommend Path.of() instead of Paths.get()

Could you report an issue against the JDK? This sounds like an oversight on their part. I previously encountered similar situations where some APIs only accepted `StringBuffer` instead of modern...