John Gathogo
John Gathogo
@ElizabethOkerio #5 in the PR description - https://github.com/OData/odata.net/pull/2880#issue-2166132628 That implementation appears to mirror the `ODataBinaryStreamWriter` implementation - https://github.com/OData/odata.net/blob/main/src/Microsoft.OData.Core/ODataBinaryStreamWriter.cs I wonder if any of the logic can go to a shared...
@ElizabethOkerio There's a need for a lot more (unit) tests in this pull request. I doubt very much that the 2 tests that you re-enabled cover all the code and...
Hi @johnwc. This is not an issue that should require a change to the library since it's not a bug in the implementation or a scenario that cuts across users...
@johnwc I understand. We triaged this issue earlier today and came to the same conclusion as you have. A custom payload value converter won't make it possible to report the...
The suggestion looks okay. If you can publish a pull request then we can review. Add tests to verify the changes.
@joecarl I'm also curious whether adding the `OriginalName` attribute to the interface properties only (without adding to the classes that implement the interface) could work... With respect to your pull...
The `IEdmNavigationSource` interface already supports an `IEdmType` property named `Type`. The `Type` property is initialized to `IEdmCollectionType` where the navigation source is an entity set and the [`EntitySetTypeMustBeCollectionOfEntityType`](https://github.com/OData/odata.net/blob/57572612f1ff833d395b44e6b2c498d7d0d31890/src/Microsoft.OData.Edm/Validation/ValidationRules.cs#L539) validation rule...
Move all configuration options to `ODataMessageReaderSettings` and `ODataMessageWriterSettings` and remove `ODataSimplifiedOptions`
Part of the challenge is that the public API for the URI parser has separate methods for `ParseTop`, `ParseSelectExpand` and so forth. The first time you call any of those...
`IJsonStreamReader` and `IJsonStreamWriter` were introduced because a standard definition for the interfaces but `IJsonReader` and `IJsonWriter` could not be changed at the time. If we think all readers and writers...