odata.net
odata.net copied to clipboard
Add IJsonStreamWriter implementation to ODataUtf8JsonWriter
ODataUtf8JsonWriter
should implement IJsonStreamWriter
(Async
) API to have full parity with JsonWriter
.
Assemblies affected
Which assemblies and versions are known to be affected e.g. OData .Net lib 7.x
Reproduce steps
The simplest set of steps to reproduce the issue. If possible, reference a commit that demonstrates the issue.
Expected result
What would happen if there wasn't a bug.
Actual result
What is actually happening.
Additional detail
Optional, details of the root cause if known. Delete this section if you have no additional details to add.
This issue was resolved by this: https://github.com/OData/odata.net/pull/2416
This interface has not yet been implemented by ODataUtf8JsonWriter
.
We should also implement the async version IJsonStreamWriterAsync
.
The stream writer APIs will allow the ODataUtf8JsonWriter
to handle stream-based inputs without having to buffer the entire content in memory.
IJsonStreamReader
and IJsonStreamWriter
were introduced because a standard definition for the interfaces but IJsonReader
and IJsonWriter
could not be changed at the time. If we think all readers and writers should support the incremental methods in IJsonStreamReader
and IJsonStreamWriter
, we should combine them into one interface. Merge methods in IJsonStreamReader
and IJsonStreamReader
into IJsonReader
and IJsonWriter
respectively ~ Mike Pizzo
This issue was resolved by https://github.com/OData/odata.net/pull/2880 (ODL 8) and https://github.com/OData/odata.net/pull/2931 (ODL 7)