odata.net icon indicating copy to clipboard operation
odata.net copied to clipboard

Add IJsonStreamWriter implementation to ODataUtf8JsonWriter

Open habbes opened this issue 2 years ago • 4 comments

ODataUtf8JsonWriter should implement IJsonStreamWriter(Async) API to have full parity with JsonWriter.

Assemblies affected

Which assemblies and versions are known to be affected e.g. OData .Net lib 7.x

Reproduce steps

The simplest set of steps to reproduce the issue. If possible, reference a commit that demonstrates the issue.

Expected result

What would happen if there wasn't a bug.

Actual result

What is actually happening.

Additional detail

Optional, details of the root cause if known. Delete this section if you have no additional details to add.

habbes avatar Jun 02 '22 08:06 habbes

This issue was resolved by this: https://github.com/OData/odata.net/pull/2416

ElizabethOkerio avatar Apr 12 '23 06:04 ElizabethOkerio

This interface has not yet been implemented by ODataUtf8JsonWriter.

habbes avatar Jul 21 '23 14:07 habbes

We should also implement the async version IJsonStreamWriterAsync.

The stream writer APIs will allow the ODataUtf8JsonWriter to handle stream-based inputs without having to buffer the entire content in memory.

habbes avatar Aug 22 '23 13:08 habbes

IJsonStreamReader and IJsonStreamWriter were introduced because a standard definition for the interfaces but IJsonReader and IJsonWriter could not be changed at the time. If we think all readers and writers should support the incremental methods in IJsonStreamReader and IJsonStreamWriter, we should combine them into one interface. Merge methods in IJsonStreamReader and IJsonStreamReader into IJsonReader and IJsonWriter respectively ~ Mike Pizzo

gathogojr avatar Feb 16 '24 19:02 gathogojr

This issue was resolved by https://github.com/OData/odata.net/pull/2880 (ODL 8) and https://github.com/OData/odata.net/pull/2931 (ODL 7)

habbes avatar May 27 '24 05:05 habbes