Matt Westcott

Results 562 comments of Matt Westcott

Thanks @kunal0297! You are welcome to work on any issue that isn't already being worked on - you don't have to ask to be assigned. Please see https://github.com/wagtail/wagtail/wiki/Why-you-shouldn't-ask-to-be-assigned-an-issue

@arup1221 Yes, anyone is free to work on any issue - no need to ask permission.

As noted on https://github.com/wagtail/wagtail/pull/11410#issuecomment-1874450755, we intentionally use `pageurl` on these links to ensure that these links are correct on single-site projects even when the Site record isn't set correctly -...

Unless I'm forgetting something, `page.url` is functionally the same as `{% pageurl page %}` (in terms of when it does and doesn't include the hostname), but less efficient because it...

@kehach07 You are welcome to work on any issue that isn't already being worked on - you don't have to ask to be assigned. Please see https://github.com/wagtail/wagtail/wiki/Why-you-shouldn't-ask-to-be-assigned-an-issue

Some additional clarification: This template was left out of the fixes for #10125 made in PR #10157 because it was not possible to make the change without increasing the query...

@laymonage Thanks for the extra info! What would you say is the best resolution for this issue then - close as wontfix, or make the change and incur the extra...

Thank you all for your interest! However, please note that the description says: > Assigning to @laymonage, this requires core team expertise. While the goal of this issue is to...

@ahosgood I'm 99% sure it's the former - same quality, smaller file size.

@mishraa-G Thanks for your interest! There is already an open pull request #13620 for this - you're welcome to review that one and provide feedback if you've found a better...