Matt Westcott comments

Results 492 comments of


                                            Matt Westcott

Clean up StreamField get_prep_value / get_db_prep_value post Django 4.2

Superseded by #12269

Fix integration test configuration

@thibaudcolas Assigning you for review on this... hopefully the updates to the testing infrastructure are uncontroversial enough, but would really appreciate your input on whether https://github.com/wagtail/wagtail/pull/12203/commits/5dab8c86b36b537d4a1b7f583bccd4153944b567 is a legitimate fix...

Fix integration test configuration

> (actually I see the 'delete' buttons are missing an aria-label, which I'll fix shortly) Sorry, scratch that... I was thinking we could give them a label like "Delete permission...

Render listing buttons as components (version 2)

Some assorted not-fully-formed thoughts, about this PR but also the situation that got us here: It kind of sucks that a developer has to know the correct FooButton class to...

Fix child restriction admin form when ancestors page view restrictions exists (#4277)

Merged in 83a390661fe30db9270c3fcbc07fe0f88f0095dc

Search on MySQL ProgrammingError(1064, "syntax error, unexpected ')'")

Confirmed on current Wagtail main. Steps to reproduce: ``` wagtail start mysqlsearch cd mysqlsearch pip install mysqlclient ``` in settings/base.py, change DATABASES to ``` DATABASES = { "default": { "ENGINE":...

Search on MySQL ProgrammingError(1064, "syntax error, unexpected ')'")

The out-of-the-box search functionality from the project template does not use `parse_query_string` - it [passes the entered search query straight to `.search()` as a string](https://github.com/wagtail/wagtail/blob/4f36562de7f1461de6202f4bd44b58cbbee00833/wagtail/project_template/search/views.py#L9-L14) - so the expected behaviour...

Search on MySQL ProgrammingError(1064, "syntax error, unexpected ')'")

A minimal snippet to reproduce the error, replicating what the search backend is doing internally: ```python from wagtail.search.backends.database.mysql.query import Lexeme, MatchExpression, SearchQuery from wagtail.search.models import IndexEntry from django.db.models.fields import BooleanField...

Save and continue: where users are redirected to after saving/publishing

Makes sense... I'd go along with that. As a slight refinement - for people making use of the [subpage_types](http://wagtail.readthedocs.org/en/latest/core_components/pages/creating_pages.html?highlight=subpage_types#wagtail.wagtailcore.models.Page.subpage_types) feature - we could have it so that it adds a...

Save and continue: where users are redirected to after saving/publishing

Thanks for the feedback @BigWhale! I suspect - albeit without any hard evidence - that the pattern of publishing a page and then working on it some more is the...