Results 1654 comments of Gabriel Scherer

Thanks! #12534 is waiting for a review, and also #12555. The two PRs are independent. (There was a decision to make between #12555 and #12556 which are competing approaches to...

Great news, thanks! (I was thinking of pinging again, but turns out this was also on your mind.)

Yep, it's not fixed yet. (I wish!) But the PRs still in flight should be enough to fix it.

@Octachron, @lthls, @trefis: at the current point in time, all standing PRs for this issue have been reviewed and approved by @ncik-roberts, they are all rebased on the current trunk,...

Here is a modest counter-proposal, based on the principle that `$` is an escaping character, whose interpretation depends on what follows: 1. the dot is now written `$$` (previously: `__`)...

The implementation mechanism for interrupting all domains in this PR is somewhat custom: it uses the same interruption mechanism as STW sections, but it is not implemented as a STW...

> An earlier work (https://github.com/ocaml/ocaml/pull/13010) did use an STW for convenience, and some people commented this was probably overkill. But I agree that it was simpler to write as an...

Aside: I thought of trying to implement a domain-safe `caml_shutdown` myself to try to understand this better, and then I remembered that writing tests for this is tedious. I thought...

I don't think I will be able to do a full review soon, but I had a quick look at it seems that the PR is moving in the direction...

This is a different trade-off than the `__LOC__` and cie. primitives that were added in 4.02: your solution is more convenient to use, but inserts an ugly hack in a...