Gabriel Scherer
Gabriel Scherer
Thanks to the annoying bot I reviewed this issue: - #12160 was proposed to solve this issue but the implementation approach is not good enough, and I think we will...
I think the main reason why the "cleanup at exit" mode is not supported in 5.0 is that no one actively worked on it. @edwintorok would you be interested in...
I thought about `with_new_level` or `with_next_level`. > We would end up with two distinct (non-linear) extensions of the same environment in the same function, which sounds confusing. I don't find...
Personally I think that tracking the level in the environment has a lot of merit, but I think we could do these sort of refactorings incrementally, leaving this suggestion to...
@t6s currently the [commit list](https://github.com/ocaml/ocaml/pull/11536/commits) for this PR shows two commits at the beginning that seem unrelated, is this intentional?
I see, thanks! Next time, do not hesitate to send such smaller independent changes into independent PRs. They are much smaller and easier to review than the big PR, and...
> and tried to explain why when I chose a different way. Yes, (of course) feel free to disagree with some of the suggestions and explain so. Thanks! I will...
Being explicit about the things we take out of the level/scope is good, but right now this involves a lot of redundancy. The "telescope" (the environment exported from within the...
The problem here is that you have to declare the record type in advance, and in particular give the type of the fields, and this is so syntactically heavy that...
Thanks!