Gary Pennington

Results 127 comments of Gary Pennington

I've done some investigation of the problem and figured out how to preserve headers from subgraph responses to the execution response. The tricky bit now is how to expose configuration...

I think the existing code pre-dates the creation of the installer script, so bringing it into line with the installer seems sensible. Would there be a timing issue during the...

Re-examine requirements for `ServiceBuilderExt` and `ServiceExt` and ensure that if both are still required they are consistent and everything is well-named.

Should we remove: - cache ?

Talked about this with @SimonSapin during our API:1.0 review and he raised the point that it will be difficult for a programmer to deal with runtime errors due to handling...

> ok so the `headers_are_available` method is there, but maybe the name should be more explicit about its usage? Somethings like `response_headers_available` because the headers would obviously be available in...

This may not be a Rhai issue, but a plugin issue: i.e. you would have the same problem if you did this from a rust plugin. I'll confirm that as...

I've verified that this is a "plugin" problem by trying to do the same thing from a rust plugin and getting the same result. I think the solution will be...

After a little digging, I've confirmed that the root cause of the problem is the CORSLayer which is operating in the router. By default, the layer sets the `vary` headers...

More digging shows that setting an empty `.vary([])` list when creating the CorsLayer means no default value is set and any value set by users is preserved. I'll proceed with...