router icon indicating copy to clipboard operation
router copied to clipboard

update the released package name in Docker image construction

Open Geal opened this issue 2 years ago • 3 comments

We changed the released package names in #1393 to include the full target triplet

:warning: do not merge this until we have published a release containing #1393

Geal avatar Jul 13 '22 13:07 Geal

@Geal your pull request is missing a changelog!

github-actions[bot] avatar Jul 13 '22 13:07 github-actions[bot]

@Geal @garypen Couldn't both the waiting for the release and the "forward support only" both be avoided if we used the installer script rather than the direct link to the tarball? The installer script works off GitHub Releases so the latest points to the latest release and the installer that gets used is based on the install.sh script rather than the hard-coded link to the tarball.

I'd also argue that we should be doing that anyways to make sure all the downloads are going through an endpoint that we control. If that makes sense, I'm happy to make a PR.

abernix avatar Jul 18 '22 12:07 abernix

I think the existing code pre-dates the creation of the installer script, so bringing it into line with the installer seems sensible. Would there be a timing issue during the processing of the release?

I presume the PR would be to replace the explicit ADD of a version with a RUN of the installer?

garypen avatar Jul 18 '22 13:07 garypen

closing in favor of #1629

Geal avatar Aug 26 '22 11:08 Geal