garylin2099

Results 35 comments of garylin2099

> Are the test cases enough? Not enough yet. Since its target is not main, I suggest merging it first if needed. Tests must be supplemented if merge is filed...

Let me clarify the question, so DI is expected to generate a string for your downstream tasks, and you want the string to contain the file name instead of the...

You are right, the problem is that the llm gave an empty response. Your running record: ![image](https://github.com/geekan/MetaGPT/assets/44922098/be681ace-add1-4ca8-b21a-11e955a5ded7) What it is supposed to be (from my run just now): ![ed15e532-d343-4b93-a684-0337d6235301](https://github.com/geekan/MetaGPT/assets/44922098/30a74065-da64-4354-9238-55e497374809) May...

Can you try using the original one below to see if the issue still exists? You have access to openai in github codespace without proxy. ``` OPENAI_API_BASE: "https://api.openai.com/v1" ``` >...

I recommend using main, too. From your log, the original temperature issue is fixed, which is good. The problem is Gemini did not follow the instruction to generate response in...

先合入,后面优化

![Screen Shot 2024-01-31 at 10 08 49 PM](https://github.com/geekan/MetaGPT/assets/44922098/f73671f5-012a-486b-b95a-db10d4a136cd) https://github.com/geekan/MetaGPT/actions/runs/7726960897/job/21064351903?pr=736 Reached test coverage 86%. No lower than target branch dev. In terms of 8 test failures, 6 of them depend on...

![Screen Shot 2024-02-01 at 12 57 37 PM](https://github.com/geekan/MetaGPT/assets/44922098/3d48d466-ee35-4ccc-baf7-aefebf3f3706) https://github.com/geekan/MetaGPT/actions/runs/7735868125/job/21092824632 Test coverage at 87%, higher than target branch (dev), all tests passed (5 failures at dev not related to this PR)

> 1. Don't write comments that don't make sense, if the subclass's methods are nothing special, it should probably use the parent's comments > 2. Notice that some logic has...

fixed in https://github.com/geekan/MetaGPT/pull/717