Garrett LeSage

Results 767 comments of Garrett LeSage

> I don't believe a normal user should be able to create a system session ever? Only when they have admin access. I'm pretty sure the original design was to...

We do have a pending redesign of this page (for the past few years); it would be good to integrate this into that, whenever someone works on it. (https://github.com/cockpit-project/cockpit-machines/issues/553#issuecomment-1061581973) Meanwhile,...

Agreed; this should work by default and shouldn't have to expose any configuration UI. Creating a VM in UEFI mode should _ideally_ automatically create a software TPM compatible with Windows...

Should a UEFI VM without a TPM be considered a bug? Should we automatically add it? Or have an inline alert banner to add it, or something like that?

I thought for sure it was using a `.vv` extension for this file. This is probably either a regression or some change in browser behavior. As far as `vnc://`, that...

Overall, for the concept: Yes. --- However: For HTML documents, H1 should be reserved for the visible toplevel elements of the page, and H2 are the main headers, without skipping...

> add the aria title to the Page element itself I don't think that is an advisable approach. Generally, you want to avoid from using any ARIA, unless it's needed....

Note: Sub-pages should have unique H1 titles. Perhaps something like "Virtual machines: details", if screen-reader-only? I'm not sure how dynamic that should be, like if it should include the name....

However, as I pointed out above, according to all specs and web developer docs, it is critical to have an `H1`. We cannot skip directly to `H2`; there _must_ be...

When you're creating snapshots, you do not want to mount them, or set up auto mounting? I don't understand why mounting is half the dialog. Snapshots of subvolumes are intended...