Garrett LeSage

Results 767 comments of Garrett LeSage

PatternFly has expandable alerts: https://www.patternfly.org/v4/components/alert/#expandable-alerts However, I'm not suggesting that we show a title like "Message of the day" or something silly like that. I'm saying we should show the...

@MahmoudHamdy02: I can't tell if that's close to right or not without a PR. - I can tell that it does have the issue with the title and body having...

PatternFly has the (!) and error states for inputs when things are invalid: https://www.patternfly.org/components/forms/form#invalid ![image](https://github.com/cockpit-project/cockpit/assets/10246/ce4a9b7f-c871-4c63-a7a9-90f5d1429745) Can we set the states for the invalid forms properly? Also, the elements are overlapping...

Specifically, the date and time should look like this: ![image](https://github.com/cockpit-project/cockpit/assets/10246/80bf3a30-9e5b-499e-be52-fd0cf90419a9) ![image](https://github.com/cockpit-project/cockpit/assets/10246/8eb1f8a8-e871-41fb-99d2-a83082a63ac5) I'm not sure why the (!) is on opposite sides. I guess the calendar is a button and the...

Mockups. First is the label on the left size (without wrapping), but this is a little too wide. We might actually want to use stacked labels (which is the PF...

OK, here's one where I backported the changes from the default into the merged set of mockups: ![image](https://github.com/cockpit-project/cockpit/assets/10246/640e7175-86b4-4b47-8c06-9437a2b78c19) Anyway, I think this should be handled in multiple PRs; I don't...

For a point of reference, I think it's good to have a short string that's right under the error. Here's what it looks like without being aligned (either to the...

Everything that @Venefilyn said above, and one additional reason why we went with the bottom bar: Cockpit has the ability to have third-party embedded app pages. If someone makes an...

Yep, agreed. When in Anaconda mode, Cockpit Storage: 1. should not try to download additional packages 2. should not have iSCSI or Stratus _for desktop editions_ (even when it has...

@mvollmer: Yes, don't have any auto-install anything when in Anaconda. It should only be able to use features already available from installed packages only. Examples: - If there's iscsi, nfs,...