Garrett LeSage
Garrett LeSage
I think this was closed with https://github.com/cockpit-project/cockpit/pull/17774. The expander serves as a warning enough already.
Hopefully this one passes the tests. I'm testing it manually and haven't seen the page header height / padding problem. But I do see inconsistent page headers, which isn't really...
> Can you please take a look? Sure. Where are the screenshot tests? I looked at the screenshots at https://cockpit-logs.us-east-1.linodeobjects.com/pull-17795-20221013-121141-f3ff12b9-fedora-37/log.html (f37) and https://cockpit-logs.us-east-1.linodeobjects.com/pull-17795-20221013-121141-f3ff12b9-rhel-9-2/log.html (rhel 9.2) and they all seemed fine...
Yeah, @jelly and I talked about this on IRC last night: we need to undo the undo and use Red Hat Display for the heading fonts, but that should be...
OK, I went through that HUGE list of differences and it all looks good! Let's merge. :partying_face: (Next step: Let's try out whatever version fixes dark theme. But that's _after_...
I know @mvollmer has been working on Stratis support. He can probably comment more on the state of it within Cockpit here.
Wow, that's a problem. We can't just force it to not truncate the versions, as some versions are really long. But the table _should_ definitely give more room for versions...
Fixing relative widths is definitely a good idea. We'd still want to manually adjust the version string using something other than percentages, however, to make the version string a "reasonable"...
Additionally, turning on tabular numbers for the versions would be nice to have. We need to start using the improved font. (It's more critical in other places, but it would...
Yes, `className` should be able to be passed too. But it would be great to have this automatically handled, as we already have the header string, so we know what...