Vishesh Garg

@LakshSingla : There needs to be some way to track if a dimension was originally a metrics but ended up being a dimension because of `finalizeAggregations=true`. So went with a...

@LakshSingla > Why is this not supported? Didn't add this support because ideally, when query granularity is `ALL`, all rows for the compacted datasource should have the same timestamp. In...

@kfaraz @LakshSingla Thanks for your comments -- I do see the usefulness of the UTs for the entire MSQ-based compaction flow. The existing tests in `CompactionTaskRunTest` however cannot be parameterised...

Thank you @kfaraz, @LakshSingla and @cryptoe for the time and effort to do all those rounds of reviews, esp. given the size of the PR.

> Left some comments. We should also add a assert to the compaction config in MSQReplaceTests. A clarification: this PR **doesn't** implicitly set the compaction state for all MSQ replace...

> Would it be better to extract the `dataSchema`, `indexSpec`, `granularitySpec` and (compute) the `partitionsSpec`, and use a common utility for both native batch and MSQ? The bulk of the...

> I think we are interested in storing the compaction state to prevent additional compactions from running on an already compacted interval. I've moved the annotation function calculation to a...

@cryptoe @kfaraz Tested it on local cluster. Storing compaction state and triggering compaction only if states differ are working as expected. However, the defaults for DynamicPartitionsSpec weren't matching with those...

I wasn't able to reproduce this issue. Hope the `indexSpec` was being submitted as part of the `tuningConfig` as detailed at the [Supervisor API](https://druid.apache.org/docs/latest/ingestion/supervisor#supervisor-spec) page; else it will pick the...