Gareth Rees

Results 577 comments of Gareth Rees

Sorry I didn't get time to look at this a few months back. It looks like you need the first field to be `#id` with empty values, contrary to the...

I've made an initial clarification/fix at https://github.com/mysociety/alaveteli/pull/4184 – it needs a bit more checking, so we'll pick that up next sprint.

Honestly, the CSV import code is pretty 🍝 . I think it needs a bit of a rebuild. Sorry about the pain its causing :(

@RichardTaylor could you attach the csv you used so that I can compare?

``` $ file Downloads/schoolsimport.csv Downloads/schoolsimport.csv: UTF-8 Unicode (with BOM) text, with CRLF line terminators $ file Downloads/stps.csv Downloads/stps.csv: UTF-8 Unicode text, with very long lines, with CRLF line terminators ```...

> Last night I discovered the dry run passes if the tag column is left out (without the #id column) There does seem to be some weirdness between the `id`...

The [RFC](https://datatracker.ietf.org/doc/html/rfc4180#section-2) says CSVs should use `CRLF`.

Some comments summarised from https://github.com/mysociety/alaveteli/issues/6586: * Pages without the images look dull in comparison * Marginally more preference towards the banner style, but general approval of both * There could...

> Noting the moment of travel on https://github.com/mysociety/alaveteli/issues/1155#issuecomment-963128672- would [ActiveStorage variants](https://guides.rubyonrails.org/active_storage_overview.html#transforming-images) help us here? Yep, that's what we'd use. > Sadly, they don't look great on the pro request form:...

My idea for this at the Alaveteli mini-retreat was to suggest a number of popular tags (2 or 3) and then allow a free text field to let the user...