Garrett Brown

Results 222 comments of Garrett Brown

I have no style requirements here. Does this fix an issue? (It's not apparent in the description.) If yes I'll merge immediately.

Merging, as it's apparent from the code that this probably fixes an issue.

sounds good, thanks for the explanation. I reviewed all the open PRs, ran them on my Steam Deck with the udev driver, and also ran them through chat-gpt for additional...

What about demand disjunction? when you consider that regexes add propositional logic for free, it seems that you're actually getting a pretty sweet deal. As a concrete example, a scraper...

I'm entertained that you've pushed the keymapper so far. The fix looks correct, and better yet is a single line. I like the improved documentation in joystick.xml. > but from...

It looks like our release manager just bumped this to v22, but that's not too far off - we're planning to branch for v22 in the next week or two,...

jenkins build this please

@bjsvedin I had a look at your XML. I saved it in a branch so that I could experiment later. Haven't runtime tested, but I'll get this in my v21...

@bjsvedin Two feedbacks: #### Commit message formatting In `git log` your commit message looks like: ``` Modified KeymapActionGroup actions to be a multiset. This allows for hotkey overrides with the...