Georges-Antoine Assi
Georges-Antoine Assi
@julienw Could you still try rebasing this PR on the latest version of master?
Awesome. I just wanted to make sure that the errors were indeed coming from the typings, and that any changes weren't going to fail because of an unrelated issue.
@julienw It seems the specs are failing again, and I don't think it's due to any issues in the master branch. When you get a chance, could you take a...
@Brianzchen Can you create a branch in this repo directly and try again? We can delete the branch after it's been merged.
Looking at the TS types, `Location` is generic on `LocationState`. We might want to do something similar here (and in react-router and react-native-router) as well.
Closing since you seem to have figured it out!
@kaushlakers If you're interested in making a PR for this change (and writing some tests), we'd love to have it and get some reviews on it!
I need to mull this over a little, but my gut instinct says that incomplete libdefs are better then no libdefs, as long as the untyped sections are stubbed, so...
@goodmind If you're still interested in getting this merged in, a couple tests would be stellar!
Ideally we'd have the idea of "Definition Owners", people who's get a stronger say over the contents of a definitions (be it the library's owner or an active contributor), and...