Jeremy Postlethwaite
Jeremy Postlethwaite
Now that GH-1037 was merged, I will update this branch. I will need to read up what changed to cause conflicts.
Should I create another Pull Request, in PHPUnit, to add a theme variable to [phpunit.xsd](https://github.com/sebastianbergmann/phpunit/blob/main/phpunit.xsd)? ```xml ``` The colors for low, medium, high, warning, and danger can be controlled by...
> I wonder whether we need this new `theme` configuration, or whether it would be enough to use `coverageHtmlCustomCssFile` to define custom css-variable values and reduce the PR to just...
> Please split this into two pull requests: one for the Bootstrap update and one for the functional changes. Here are the Bootstrap-only changes, for `src` and `tests`: - https://github.com/sebastianbergmann/php-code-coverage/pull/1037...
FYI: I just tried running the tests, my installation is on PHPUnit 11.3.0 and I did not see the whitespace error. - I did confirm the test `testPathCoverageForBankAccountTest` ran with...
@sebastianbergmann Should we close this PR? - I would still be willing to add an option to enable themes to add dark mode: https://github.com/sebastianbergmann/phpunit/pull/5833 - If you do not want...
> Are these visual changes intentional? > No. I am looking into this now. It could be browser specific. I am reviewing the rules in style.css; the old rules definitely...
## Expected output I updated a few rules, and undid a few modified rules. - I have not tested other browsers yet, it is possible there is an issue with...
### Findings It does appear to be a browser compatibility issue with only Firefox for relative colors: https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/rgb#browser_compatibility I went ahead and put back the original default colors into `Colors.php`:...
> Thank you for working on this. Unfortunately, I found more visual differences: > > Are these visual changes intentional? > No problem, happy to help! And no, those changes...