Josh Rose

Results 7 comments of Josh Rose

> Does adding a `key` attribute to the looped elements help? Does that mean wrapping it with a 'Fragment'? I'm AFK right now, but if that's what you mean, I...

Ah I didn't know that's possible - but no, it doesn't help

Actually the issue is more fundamental than a list with varying number of elements. It appears to be a general issue with removing nodes from the DOM. If you simply...

Just kidding, the new example code is not bad. The number of detached nodes does grow, but they eventually get garbage collected. I'll try isolate under what conditions GC fails...

I believe the problem ultimately boils down to https://github.com/DioxusLabs/dioxus/blob/bdeedc13eb504d3e05edb48575ceda52aea09eff/packages/core/src/diff/node.rs#L335C8-L335C31 calling `remove_dynamic_node(to=None, ...)`, resulting in a noop on the `Text(_) | Placeholder(_)` branch. The `ElementId` for the removed node is never...

I had a PR open for this, but I didn't get it over the finish line. @iamcco and/or @bennukem Can you try updating your dioxus dependency to `dioxus = {...

Yeah my use case was virtual scrolling as well. Glad to hear the patch works. I'll try to complete the PR