steam-deploy icon indicating copy to clipboard operation
steam-deploy copied to clipboard

feat(inputs): totp support

Open eyzi opened this issue 2 years ago • 3 comments

Changes

  • totp support (resolves #17)

Checklist

  • [x] Read the contribution guide and accept the code of conduct
  • [x] Readme (updated)
  • [x] Tests (passing on project: https://github.com/moonlitworks/without-romance/actions/runs/3193422828)

eyzi avatar Oct 05 '22 23:10 eyzi

Thanks for this! Can you check if it works with #46 too?

Tested on a successful build (https://github.com/moonlitworks/without-romance/actions/runs/3210733592/jobs/5248407873) rebased on #46

Though, a few notes:

  • I find that totp doesn't work when used twice, so i had test login only happen when it is using mfa files
  • I removed the post-entrypoint from #46 as (a) the unescaped double quotes lead to docker: invalid reference format and (b) even with the double quotes escaped, it doesn't seem to locate $(pwd)/manifest.vdf correctly. Instead, I had to set output inside the main entrypoint

ref of changes: https://github.com/eyzi/steam-deploy/commits/timewarpinc

Let me know if there are any issues with these. Thanks!

eyzi avatar Oct 08 '22 14:10 eyzi

Could you be a bit more specific about the ref of your changes? It's showing all your commits.

webbertakken avatar Oct 08 '22 15:10 webbertakken

Could you be a bit more specific about the ref of your changes? It's showing all your commits.

  • Rebased this pr on #46 to test if this works with that, as per @davidmfinol's request
  • Moved test login inside the else block to only run it when it is using mfa files
  • Attempted to fix docker error by escaping double quotes in post-entrypoint
  • Removed post-entrypoint entirely and set action output from the main entrypoint

eyzi avatar Oct 08 '22 17:10 eyzi