Gajus Kuizinas

Results 725 comments of Gajus Kuizinas

> What's the state of express-tus? Is it production-ready yet? Do you plan on including more storage options (e.g. disk and S3) such as tus-node-server and tusd do? Do you...

> Makes sense as a design decision but in that case it is not a drop-in replacement for tus-node-server? Or do storage backends already exist? `tus-node-server` could use `express-tus` or...

@sokra Please review this, as it affects the logic outside of just pathToArray (normalisation).

@sokra are you certain regarding addition/support of this test case? ``` js fs.normalize("\\\\a\\b/../c\\d\\..").should.be.eql("\\\\a\\c"); ``` It would make the code quite ugly. That is, I had a few dabs at it,...

> Here the absoluteWinRegexp need to include UNC paths. Whats the need for the addition? What test case am I missing? https://github.com/webpack/memory-fs/pull/28/commits/407053104022c5cf90b640efe04bdd21073d8349 As it is, all scenarios are covered, as...

@sokra I had a second look into this. I don't see what you want to achieve by adding the UNC path support to `absoluteWinRegexp`. UNC paths are already handled as...

> oh yeah, I was wrong. the normalization does only care for . and ... The path joining corrects the slashes. Here the absoluteWinRegexp need to include UNC paths. 3ccfa79

> So \srv\share\src/relative/path is possible, but /root/src\relative\path is not possible (it's possible but \ is not a path separator in this case). Because of this lucky circumstance we do not...

Similar issue. Described in https://stackoverflow.com/q/73161429/368691 > I am using Rollup with Vite and vite-plugin-ssr. > > The production build it produces with standard configuration includes a ton of tiny files,...