Jan

Results 9 comments of Jan

Sorry for the late reply, @NightGoat! I like the property delegate approach, I'll review your PR tomorrow :)

Generally I'm fine with your implementation, though I was thinking of how we could improve it: - I'd implement the property delegates by creating extension functions on the KVault class....

We could also add a property delegate for `existsObject()`: ```kotlin val hasPin: Boolean by kvault.exists() ```

Mostly looking good to me. I'm hesitant to use the suffix "pref", since we're not only using SharedPreferences (also doesn't feel in line with the rest of the library). The...

You could also just use Any? as the delegate owner type.

I tried parsing with your custom element and it works fine. The last merged PRs haven't been published yet, though. Do you possibly use the latest version (1.7.1)? If yes,...

I've made some changes to the regex, and the attribute inheritance. This should be fixed now.

The link color attribute gets overriden by the textViews' `linkTextAttributes`. To use the color that you defined via the parser you must clear the linkTextAttributes like this `self.textView.linkTextAttributes = [:]`....

Seems related to #66. Do your links contain parantheses in the text or url?