Gabriel Ware

Results 5 comments of Gabriel Ware

If I read the code properly, ViewportInfo should be a vec4 in the form of {1.0/original_tex_w, 1.0/original_tex_h, original_tex_w, original_tex_h}. I'll let the original authors confirm but from my tests it...

Added code to handle default locations for VS installation. Tried to minimize code duplication by generating the list of locations.

Sure. Couple questions before I do that: - We're talking about updating https://github.com/bazelbuild/bazel/blob/master/tools/cpp/windows_cc_configure.bzl . Correct? - How do I test that I didn't break anything ? What are the targets...

`Was it the version in bazel_tools or the one in rules_cc?` AFAICT the version in `rules_cc` seems cleaner; better maintained. Functions were moved to private, there are a couple fixes...

Anything left here or can we merge this ?