Gabriel Schulhof
Gabriel Schulhof
Do the APIs like napi_wrap and napi_unwrap also need to be protected, because they call `HasPrivate`, `GetPrivate`, and `SetPrivate`, which are very similar to property accessors? They also call `IsObject()`.
Do we need to protect the followings with `CheckGCAccess`? * napi_get_all_property_names * napi_get_new_target
> Do we need to protect the followings with `CheckGCAccess`? > > * napi_get_all_property_names Has NAPI_PREAMBLE, therefore has the check. > > * napi_get_new_target Needs the check, because it calls...
Great work!
There's another problem. @addaleax correct me if I'm wrong, but AFAICT can_call_into_js() can become false at any time, because, on a worker, turning off the ability to call into JS...
@addaleax would it make sense to protect the boolean flag with a mutex instead of making it atomic? This would prevent the main thread from setting it while there's a...
`yalc add` already modifies a package's package.json to replace a dependency with a "file:.yalc/..." version. Why not also modify its "files" section to mention ".yalc"?
I think this can be solved with ObjectWrap. The Napi::ObjectWrap subclass contains a linked list of `Napi::FunctionReference` objects, each of which is a weak reference. A finalizer is added to...
I think we should wait for https://github.com/nodejs/node/pull/45715 as well.
We have released Node-API version 9. Closing.