Gabriel Schulhof
Gabriel Schulhof
@Flarna NAN only targets the parts of V8 that break. You can still use a plain `v8::Local` with Nan, so that also has to be shimmed. Ideally, of course, Nan...
Also, Nan can call the V8 shim.
@robinchrist if you remove the `Release()`, and since it now works, do you get memory leaks as you reload electron many times?
@vmoroz suggested that a possible way out is to manage our queue of finalizers ourselves, and to add an epilogue to each `napi_*` and `node_api_*` function that drains the queue....
Is anyone still working on this 👋
@vmoroz IMO the asan and macos tests are unrelated. I think they may pass if you restart the jobs.
@vmoroz OK, maybe asan is legit. It's too stubborn 😄
I ran make test-js-native-api and test-node-api locally with asan and they passed.
Atch! I played around with this branch, and I don't think we can use `napi_cannot_run_js`, because we cannot conflate environment shutdown with gc running. If we did, we couldn't delete...
After discussing this in our group meeting, I understand that, since there is not much a user could do with a status code indicating that JavaScript cannot currently be executed...