Gabriel Jenik

Results 173 comments of Gabriel Jenik

Hi Denis, Generally speaking I am not too much in love in how encryption/decryption works for the token model. Not a fan of havin to encrypt and decrypt everything, just...

> But you need to have it decrypted to use it, non ? Have 2 object : one for crypted and one decrypted ? The have 2 Token object +...

> But this need to review all usage of token value and response value ? As with every other approach I guess. We need to look for the current decrypt()...

> You're opinion : model->attribute must stay always crypted, must create or update getter and setter function for decrypt/uncrtyot Yes, that was plan A. Plan B is to decrypt on...

> The question now is 1. Make decision about all of this crypt system , 2. time of dev for project. Yes, this is more decision for @olleharstedt

Master implementation implements front end validations. #2558 Let's review that before implementing the same on here.

[15195-ConParche.webm](https://user-images.githubusercontent.com/4942495/192534081-334f7646-d733-454b-9257-be401e2bcaf7.webm) Tested OK. Wasn't tested on remote control. Still taking into account this has already been merged on master, we can safely merge here as well. What do you think?...

@olleharstedt Is this ok? https://github.com/LimeSurvey/LimeSurvey/blob/develop/application/helpers/update/updatedb_helper.php#L90 This is causing new updates on DB to fail on the automated tests.

I did that. https://github.com/LimeSurvey/LimeSurvey/pull/2218/files#diff-d79139a77f31dedfa48f77ec35037910ec097711865fc4d6ed74ee04487c6cde But automated test fails as this: https://github.com/LimeSurvey/LimeSurvey/blob/develop/application/helpers/update/updatedb_helper.php#L107 Feel the code I