Gabriel Jenik
Gabriel Jenik
Probably this needs to be reviewed to check if still happens.
Thanks @lajosarpad > xml_path is at some places referenced as is, instead of using the new getRelativeXmlPath. So we are using absolute path in some cases and relative path at...
> 1. xml_path > We have QuestionTheme::search > as well as usages of getXmlPath I guess is fine. > 2. config paths > I referred to this comment: https://github.com/LimeSurvey/LimeSurvey/pull/2253#issuecomment-1072276373 >...
> currently we are awaiting for tests to be performed so if anything is missing it will be detected Yes
@tiborpacalat Can you help testing this?
> I am proposing to add a plugin event to be able to change the survey template. Why not https://manual.limesurvey.org/BeforeSurveyPage ? Also, the PR should probably point to DEV, right?
> > > I am proposing to add a plugin event to be able to change the survey template. > > > > > > Why not https://manual.limesurvey.org/BeforeSurveyPage ? >...
cast as string or strval ? I think we usually use cast as string. Probably they have the same results on most cases. Wonder why you chose strval()
> cast as string or strval ? I think we usually use cast as string. Probably they have the same results on most cases. Wonder why you chose strval() From...
> > Also, could be good to add a 1 or 2 lines about the SurveysInGroup.php model. When is that supposed to be used? > > I don't understand ?...