gaborkaszab
gaborkaszab
LGTM. Looks way better with these Immutable metrics classes.
Hi @rdblue, We have recently implemented the support for mixed file format Iceberg tables in Impala: https://issues.apache.org/jira/browse/IMPALA-10610 One use case would be to gradually migrate the files of a table...
@nastra As you are very familiar with this area, would you mind taking a quick look?
> the code changes themselves LGTM but I'm still not sure that this is how we'd want to represent **dimensions** in metrics as this doesn't really scale to add a...
Quick update: I have a PoC for the new MultiDimensionCounter type. There are some rough edges but apart from the Json conversions seems to work fine. The from-Json part is...
Thanks for the review on https://github.com/gaborkaszab/iceberg/commit/b268f65f3d588f30c637aa3db3f53be2a5f4c80d @nastra! I think I addressed most of them. The changes since the last patch: - Made the MultiDimensionCounter non-generic. - The MultiDimensionCounter receives a...
Thanks again for the review, @nastra! I believe I have addressed all of your previous comments. Another round of review would be appreciated :)
Thanks for the comments, @nastra! I believe I've addressed all of them. (plus did a rebase with master to resolve conflicts)
Hey @nastra, Would you mind taking another look?
Additionally, @danielcweeks @rdblue would you mind taking a look?