gaaclarke

Results 150 comments of gaaclarke

> @gaaclarke please merge latest from `main` to clean up CI results. Thanks! Done, FYI I'm waiting on the feature to land on stable to merge this. I'll add a...

I looked at this briefly. iOS is a bit different than Android because they don't have JIT. Wasmer has support for it though, you just have to do AOT compilation....

OP found the source of their problem, they were registering duplicate plugins. Closing.

I think the OP should use Android Studio to profile their app and look for any blocks on the platform thread (UI thread in Android parlance) that are long. The...

> The criteria for testing is not that we only test new functionality, it's https://github.com/flutter/flutter/wiki/Tree-hygiene#tests Right, the point is that the code in this PR has test coverage. It is...

@stuartmorgan I looked into adding a test at `/Users/aaclarke/dev/packages/packages/google_maps_flutter/google_maps_flutter_ios/example/ios14/ios/RunnerTests`. Those tests fail to link: ``` ld: warning: ignoring file '/Users/aaclarke/Library/Developer/Xcode/DerivedData/Runner-cfyxahhvdbsudtbrisrwbppvdqok/Build/Products/Debug-iphonesimulator/google_maps_flutter_ios/libgoogle_maps_flutter_ios.a[10](GoogleMapPolylineController.o)': found architecture 'x86_64', required architecture 'arm64' ld: warning: ignoring file...

So we do serve debug builds, but they are jit. So I'm not sure if that will work.

Test against the private API has been added. I still urge the plugin maintainers to consider a more holistic solution to testing the thread safety of platform channels. @hellohuanlin PTAL

> i could be missing something, but this doesn't seem to be related to the linked issue on tiles not being displayed, but it's rather a separate issue that you...

> Looks like once the CHANGELOG conflict is resolved, this is ready to be merged? rebased and put in the queue