samples icon indicating copy to clipboard operation
samples copied to clipboard

Added sample code for using plugins and channels from background isolates

Open gaaclarke opened this issue 2 years ago • 9 comments

Do not land until the feature is on stable.

fixes https://github.com/flutter/flutter/issues/112235

Pre-launch Checklist

  • [x] I read the Flutter Style Guide recently, and have followed its advice.
  • [x] I signed the CLA.
  • [x] I read the Contributors Guide.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

gaaclarke avatar Sep 27 '22 16:09 gaaclarke

@goderbauer please take a look.

gaaclarke avatar Sep 27 '22 16:09 gaaclarke

Thanks @goderbauer!

gaaclarke avatar Sep 27 '22 17:09 gaaclarke

@gaaclarke please merge latest from main to clean up CI results. Thanks!

domesticmouse avatar Oct 09 '22 10:10 domesticmouse

@gaaclarke please merge latest from main to clean up CI results. Thanks!

Done, FYI I'm waiting on the feature to land on stable to merge this. I'll add a note to the description and get it all set.

gaaclarke avatar Oct 10 '22 16:10 gaaclarke

@gaaclarke please merge latest from main to clean up CI results. Thanks!

Done, FYI I'm waiting on the feature to land on stable to merge this. I'll add a note to the description and get it all set.

Has this code been added to the list of CI targets in:

  • https://github.com/flutter/samples/blob/main/tool/flutter_ci_script_stable.sh
  • https://github.com/flutter/samples/blob/main/tool/flutter_ci_script_beta.sh
  • https://github.com/flutter/samples/blob/main/tool/flutter_ci_script_master.sh

domesticmouse avatar Oct 13 '22 15:10 domesticmouse

Hey @gaaclarke, I'm wondering if this feature is in beta. If yes, I'll be rolling a beta uber PR that will land when stable increments that this PR could be included in.

domesticmouse avatar Jan 09 '23 22:01 domesticmouse

@domesticmouse, yep! It's on beta.

gaaclarke avatar Jan 10 '23 00:01 gaaclarke

Integrated into https://github.com/flutter/samples/pull/1556

domesticmouse avatar Jan 10 '23 04:01 domesticmouse

This should now be closeable. To be sure, please resolve conflicts and you should hopefully see this PR resolve to 0 files changed.

domesticmouse avatar Jan 24 '23 23:01 domesticmouse

Land once CI turns green.

domesticmouse avatar Feb 05 '23 06:02 domesticmouse