gaaclarke

Results 150 comments of gaaclarke

> This in its current state actually breaks android platform channels of size 1 byte in the framework integration test here: https://github.com/gaaclarke/flutter/blob/2c22cd79a206503396dd31dc02074ccb66604259/dev/integration_tests/channels/lib/main.dart#L114:L114 > > That same test passes in iOS...

Update: - https://github.com/flutter/engine/pull/35804 implements Android - https://github.com/flutter/engine/pull/35803 fixes the crash we were seeing in android builds before this PR

Update: - https://github.com/flutter/engine/pull/35893 Implements support for all the desktop embedders

Thanks everyone, I'll get to work cleaning up and putting and the dependent PRs into review today.

> My primary use case is having the possibility of using EventChannels from background threads. Yea, we've enabled that for iOS and Android, see the TaskQueue API. I'm in the...

It sounds like the impetus for this change is wanting to respond to platform channel messages on background threads since @jnschulze said "My primary use case is having the possibility...

After looking at this PR more closely, the task queue work is less applicable to what this PR is solving despite the similarities at first blush. There are 2 things...

> We might get the feature as a result of implementing Isolate Platform Channels ([flutter/flutter#13937](https://github.com/flutter/flutter/issues/13937)) too which is going to happen sooner for windows. I just implemented Isolate Platform Channels...

I think there is a bit of a language problem. "Optimize" means to me making something more efficient. Since the linked issue isn't an efficiency problem, it is a visual...

I think the easiest thing would be to have a dart unit test for this that imports the `package:pigeon/pigeon.dart` and references swiftoptions such that if you removed the line you...