packages icon indicating copy to clipboard operation
packages copied to clipboard

[pigeon] feat(pigeon): expose SwiftOptions

Open Lyokone opened this issue 2 years ago • 6 comments

Exposing SwiftOptions which are missing for pigeon.

Pre-launch Checklist

  • [X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [X] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [X] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • [X] I signed the CLA.
  • [X] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • [ ] I listed at least one issue that this PR fixes in the description above.
  • [X] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [X] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] I added new tests to check the change I am making, or this PR is test-exempt.
  • [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Lyokone avatar Jun 23 '22 08:06 Lyokone

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Jun 23 '22 08:06 flutter-dashboard[bot]

Thanks for the submission! This will need a test per the comment above before we can move forward with it.

stuartmorgan avatar Jun 28 '22 20:06 stuartmorgan

Hello, since it's just an export, I'm not sure how to test that? 🤔

Lyokone avatar Jun 28 '22 20:06 Lyokone

Presumably you are adding this for a reason; what were you trying to do that didn't work without that PR? That's what you should test.

stuartmorgan avatar Jun 28 '22 20:06 stuartmorgan

I don't know either how test it. But maybe updating the pigeons/message.dart and adding new tests in test/pigeon_test.dart could validate?

ailtonvivaz avatar Jul 04 '22 15:07 ailtonvivaz

I think the easiest thing would be to have a dart unit test for this that imports the package:pigeon/pigeon.dart and references swiftoptions such that if you removed the line you added the test would no longer compile.

gaaclarke avatar Jul 21 '22 17:07 gaaclarke

@Lyokone Are you planning on adding a test per the discussion above?

stuartmorgan avatar Aug 23 '22 20:08 stuartmorgan

Hello, sorry I forgot about this. I'll do it today

Lyokone avatar Aug 24 '22 06:08 Lyokone

@tarrinneal It's fixed :)

Lyokone avatar Aug 25 '22 06:08 Lyokone