Joe

Results 24 comments of Joe

@SwapnilDreams100 I'm hitting this error now with an adapter setup that worked before the refactor. ``` ERROR 07-03 19:42:16 async_llm_engine.py:54] Engine background task failed ERROR 07-03 19:42:16 async_llm_engine.py:54] Traceback (most...

For https://github.com/vllm-project/vllm/pull/4645#issuecomment-2207110714, removing the enforce eager flag causes the error to go away. @SwapnilDreams100 I built from https://github.com/SwapnilDreams100/vllm/pull/2 and sent requests to the openai completion endpoint made with a command...

@SwapnilDreams100 first of all congrats! I'd like to add tests for the openai server, would it be best to wait for this to merge so I can open my own...

This might help depending on your requirements: https://github.com/vllm-project/vllm/issues/15131#issuecomment-2748761337 I think you should make this a feature request rather than a bug. I do think easier access to logits is a...

@DouweM is there a source of truth I can reference for what the schema output _should_ be for tests? I think I will get stuck figuring this out so any...

@DouweM thanks for the reviews so far. Fixed: ~~The PR has an issue where it always adds `str` to the output schema if the `AutoOutputSchema` is selected. However I think...

I don't know how to properly fix the coverage issue 😬

@DouweM it is ready! Apologies.

@DouweM how should duplicate tool output types be handled? For example: ``` output_type=[ToolOutput(bool, name='one'), ToolOutput(bool, name='two'), ToolOutput(bool, name='three')] ``` Can it be: ``` {'anyOf': [{'type': 'boolean'}, {'type': 'boolean'}, {'type': 'boolean'}]}...

@DouweM ready for review. The test failure doesn't appear to be from this PR. I have one question about whether we should remove duplicate output types: https://github.com/pydantic/pydantic-ai/pull/3454#issuecomment-3590056924