Fabien ZARIFIAN

Results 7 comments of Fabien ZARIFIAN

@gartens Something went wrong on your tests (see flake8 core tests)

@felixfontein the value is not mandatory, but passing the argument as null fails

```python def create_or_update_group(self, name, parent, options): changed = False payload = { 'name': name, 'path': options['path'], 'visibility': options['visibility'], 'project_creation_level': options['project_creation_level'], 'auto_devops_enabled': options['auto_devops_enabled'], } if options.get('project_creation_level'): payload['project_creation_level'] = options['project_creation_level'] if options.get('subgroup_creation_level'):...

Some typos in my payload, remaining `'subgroup_creation_level': options['subgroup_creation_level'],` after putting it in optional : works great :) This one resolve : - the broken creation - the idempotency for those...

the implementation of the check_mode is also interresting, but not the PR subject too

In reality, only two parameters are mandatory in gitlab implementation. - name - path (slugified name, which should be a method defined in module_utils, and not the code used because...

The better way to restart a container seems to be : - stop the running container with this docker command : `docker stop $(docker ps -f name= -q)` - restart...