Knowledge2Pixels

Results 18 comments of Knowledge2Pixels

Adding just one attribute looks stupid, or is there a better way to pass in react-draggable props?

> @STRML @fxxjdedd Is there any update on this? I am trying to use these changes made but this issue still seems to remain.. I am passing down `enableUserSelectHack={false}` from...

This PR was originally used to solve this problem: before dragging, react-draggable will dynamically change the style of HTML tags, thus disabling user select. In most cases, it works well,...

@nikhil-varma Thanks, i have fixed it

@STRML I made some changes according to your suggestion. But it is difficult to make it perfect, since we have extracted the properties (cancel, handle, ...) of `draggableOpts` as props...

Should we also add `draggableOpts` to `LayoutItem` to control a single GridItem?

> This will add the styles multiple times, I doubt that is desired. This is indeed a problem, Maybe we need an extra `if` in `handledrag`. However, it is necessary...

@STRML Hello, I found that `addClassName` already has logic to avoid duplicate classes. However, I can add another `hasUserSelectStyles` judgment if necessary.

@mesqueeb You need to distinguish between jsx and tsx. All libs with jsx are about how to convert jsx to vue's render function, such as: - @babel/plugin-syntax-jsx - @vue/babel-helper-vue-jsx-merge-props -...