Florian Weingarten
Florian Weingarten
The general idea of rewriting bad templates into good templates makes a lot of sense to me. I remember there might have been a prototype (hackdays?) for this already a...
Hm I kinda feel like it would be cleaner if all those `format` methods would not be on the tags themselves. They are cluttering the code a bit, imho.
I think I would prefer this to be implemented in a more "unintrusive" way, as a separate class for example.
Hm. Good catch. I agree that it makes more sense like this. But this fix is not strictly backwards compatible... @Shopify/liquid, think we can ship this without breakage?
There is an argument to be made here that ``` for item in array reversed limit:2 ``` and ``` for item in array limit:2 reversed ``` should not behave the...
Good point :-) Can you rebase this PR?
Then maybe lets just implement the new syntax as well?
@pushrax: What should we do here? Add some logging to Shopify first to see if we can ship this without breakage? It's not backwards compatible.
> I need to get the harness set up for that again @pushrax: Any intentions of still doing this?
Still seems broken... any update?