Florian Weingarten
Florian Weingarten
Can you benchmark the performance impact of this?
@dylanahsmith: Were you still planning to ship this?
No objections in general but maybe we should add some logging/instrumentation to this codepath first and confirm that it's not used in production?
Should we have a test with a variable which has a Proc as a value and the Proc returns nil? And then assert that it's using this nil now instead...
Hm I think we tried to fix this before and we didn't merge it because it negatively impacted performance by quite a bit. @trishume might remember.
Does this bug exist in the strict parser as well?
Isn't this the same as `{{ items | join: ", " }}`?
Sorry, I should read the whole description before answering :-)
I'm pretty indifferent about this... @pushrax @dylanahsmith? @carolineschnapp you think this would be useful?
@nickpearson: Can you rebase this?